[SPARK-25352][SQL][Followup] Add helper method and address style issue#22409
Closed
viirya wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-25352][SQL][Followup] Add helper method and address style issue#22409viirya wants to merge 1 commit intoapache:masterfrom
viirya wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
Member
|
LGTM. Wait for the test. Thanks. |
|
Test build #96022 has finished for PR 22409 at commit
|
Member
Author
|
retest this please. |
Contributor
|
LGTM |
|
Test build #96025 has finished for PR 22409 at commit
|
Member
Author
|
retest this please. |
|
Test build #96037 has finished for PR 22409 at commit
|
hvanhovell
approved these changes
Sep 13, 2018
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - merging to master/2.4
asfgit
pushed a commit
that referenced
this pull request
Sep 13, 2018
## What changes were proposed in this pull request? This follow-up patch addresses [the review comment](https://github.com/apache/spark/pull/22344/files#r217070658) by adding a helper method to simplify code and fixing style issue. ## How was this patch tested? Existing unit tests. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #22409 from viirya/SPARK-25352-followup. (cherry picked from commit 5b761c5) Signed-off-by: Herman van Hovell <hvanhovell@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This follow-up patch addresses the review comment by adding a helper method to simplify code and fixing style issue.
How was this patch tested?
Existing unit tests.